Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support token_type and allowed_response_headers in github_auth_backend and jwt_auth_backend #556

Merged
merged 5 commits into from
Oct 10, 2019

Conversation

shwuandwing
Copy link
Contributor

This partially resolves #555.

@shwuandwing
Copy link
Contributor Author

@tyrannosaurus-becks, @kalafut -- is there anything else I need to do to get this PR reviewed, approved and merged?

@kalafut
Copy link
Contributor

kalafut commented Oct 8, 2019

@shwuandwing I hope to get to this in the next couple of days. Thanks for your patience!

@kalafut kalafut self-assigned this Oct 8, 2019
Copy link
Contributor

@kalafut kalafut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@kalafut kalafut merged commit 5f2cbdb into hashicorp:master Oct 10, 2019
dandandy pushed a commit to dandandy/terraform-provider-vault that referenced this pull request Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants