Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/pki crl config #506

Merged
merged 8 commits into from
Sep 30, 2019
Merged

Feature/pki crl config #506

merged 8 commits into from
Sep 30, 2019

Conversation

billyaustin84
Copy link
Contributor

This resolves #472.
This is my first attempt at Go, so all feedback is gratefully received.

@ghost ghost added the size/L label Aug 15, 2019
@ghost ghost added the documentation label Aug 16, 2019
@tyrannosaurus-becks tyrannosaurus-becks self-assigned this Sep 3, 2019
Copy link
Contributor

@tyrannosaurus-becks tyrannosaurus-becks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking fantastic! Very impressive for a first try at Go. Just a couple of minor things and I think it'll be ready to merge. Thank you!

vault/resource_pki_secret_backend_crl_config.go Outdated Show resolved Hide resolved
@billyaustin84
Copy link
Contributor Author

@tyrannosaurus-becks Many thanks for your positive and constructive review. I have addressed where possible.
My circleci build failed but for apparently unrelated reasons:
fatal: unable to access 'https://git.apache.org/thrift.git/': Failed to connect to git.apache.org port 443: Connection timed out
I don't have permissions to start it again, would you mind restarting it please?

Copy link
Contributor

@tyrannosaurus-becks tyrannosaurus-becks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@billyaustin84 perfect! Thank you for submitting this PR.

@tyrannosaurus-becks tyrannosaurus-becks merged commit 362e318 into hashicorp:master Sep 30, 2019
dandandy pushed a commit to dandandy/terraform-provider-vault that referenced this pull request Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to Configure CRL Expiry for PKI engine
2 participants