-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/pki crl config #506
Feature/pki crl config #506
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking fantastic! Very impressive for a first try at Go. Just a couple of minor things and I think it'll be ready to merge. Thank you!
@tyrannosaurus-becks Many thanks for your positive and constructive review. I have addressed where possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@billyaustin84 perfect! Thank you for submitting this PR.
…onfig Feature/pki crl config
This resolves #472.
This is my first attempt at Go, so all feedback is gratefully received.