add new JWKS options for the JWT auth mount #483
Conversation
ghost
added
Vault v1.2.0 added: - jwks_url - jwks_ca_pem This change provides support for the new options. Also did some refactoring on resource_jwt_auth_backend.go and its documentation in order to make them more consistent.
jcarrothers-sap
force-pushed
the
jwt_jwks
branch
from
4b253f0
to
0c8e865
Compare
Co-Authored-By: Jim Kalafut <[email protected]>
|
@tyrannosaurus-becks I've left my review history in my branch as I'm expecting you to squash this PR. Let me know if you'd like me to do otherwise. |
There was a problem hiding this comment.
@jcarrothers-sap thanks for your updates! Looks good!
Nope, don't need the commit history squashed, and I do appreciate that you left them behind because it helps with the review. I'm going to hold on merging this for the moment in case Jim wants to circle back to it, but I'll make sure to get it merged before this week's release.
|
@tyrannosaurus-becks Unfortunately this change seems to have missed v2.2.0. When do you think the next release will be and do you expect this will be in it? Thanks |
|
@jcarrothers-sap Sorry for the delay. I've had a chance to look through this and try it out, and it all looks good aside from a tiny typo. Thanks! |
Vault v1.2.0 added:
This change provides support for the new options.
Also did some refactoring on resource_jwt_auth_backend.go and its
documentation in order to make them more consistent.