-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Resources for Transit Secrets Backend #477
Add Resources for Transit Secrets Backend #477
Conversation
Howdy, @tyrannosaurus-becks! I'm back with more commits. Let me know if there's any problems with this PR so I can fix them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code, tests, and docs for this look very good. I'm thinking we should strip out the resource marked as having an unknown endpoint, but I'm flexible on that, so I'm looking forward to hearing your thoughts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Also, I saw this test failure appeared unrelated, so I did a test build after merging master and the test succeeded.
Add Resources for Transit Secrets Backend
Hi all,
I wanted a structured way to create transit backends and encryption keys via Terraform, so I went ahead and implemented it for us all.
This PR implements two new resources:
vault_transit_secret_backend
vault_transit_secret_backend_key
The transit secret backend is fairly trivial and primitive, since it's simply wrapping
vault_mount
by settingtype = "transit"
. However I wanted to control the keys within the mount so it seemed natural for there to be resource for the backend.There is more that could be done on top of this, as I have an idea to implement some new data sources around transit:
Checklist:
Acceptance test output: