Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add list type for bound claims of vault_jwt_auth_backend_role #455

Conversation

anhdat
Copy link
Contributor

@anhdat anhdat commented Jul 1, 2019

Fix #408

Bound Claims of Vault JWT Auth Backend Role supports both string and list of strings:
https://www.vaultproject.io/api/auth/jwt/index.html#bound_claims
Implementation in vault-plugin-auth-jwt: https://github.com/hashicorp/vault-plugin-auth-jwt/blob/363f5913f469fff63ab979d498ea07a57a5d2639/claims.go#L92

This PR allows user to pass a comma-separated string list, while still backward compatible with single string. For example:

resource "vault_jwt_auth_backend_role" "ops-web" {
  ...

  bound_claims = {
    department = "Engineering"
    division   = "Europe"
    email      = "[email protected],[email protected]"
  }

...
}

@ghost ghost added the size/S label Jul 1, 2019
@tyrannosaurus-becks tyrannosaurus-becks self-assigned this Jul 1, 2019
Copy link
Contributor

@tyrannosaurus-becks tyrannosaurus-becks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tyrannosaurus-becks tyrannosaurus-becks merged commit cae8ad3 into hashicorp:master Jul 1, 2019
dandandy pushed a commit to dandandy/terraform-provider-vault that referenced this pull request Jun 17, 2021
…_auth_backend_role_bound_claims

Add list type for bound claims of vault_jwt_auth_backend_role
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jwt_auth_backend rode bound claims does not support list
2 participants