Update AWS Auth Backend Role resources to take sets instead of lists #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
@lawliet89 thanks for working on this! I'm going to hold on reviewing it for the moment because I notice that it conflicts with some of the work on the branch updating to Terraform 0.12 here and I don't want to create any further merge conflicts that could slow work. |
|
Got you. Let me know when I can try and update the pr to resolve any future
issues.
|
|
@tyrannosaurus-becks #446 is merged and I have merged the latest master cleanly into this PR. |
tyrannosaurus-becks
approved these changes
Jul 1, 2019
dandandy
pushed a commit
to dandandy/terraform-provider-vault
that referenced
this pull request
Jun 17, 2021
Update AWS Auth Backend Role resources to take sets instead of lists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes #409 and fixes the tests in that PR.
Also makes everything else sets since there is no point in allowing non-unique items.
Fixes #385