Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pki config urls #399

Merged

Conversation

edmeister
Copy link
Contributor

This PR adds functionality to set the issuing certificate endpoints, CRL distribution points, and OCSP server endpoints that will be encoded into issued certificates.

Fixes #363

@edmeister edmeister changed the title Add pki config urls #363 Add pki config urls Apr 23, 2019
@tyrannosaurus-becks tyrannosaurus-becks self-assigned this Apr 30, 2019
Copy link
Contributor

@tyrannosaurus-becks tyrannosaurus-becks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Tests are passing. Just the one question and good to go.

Copy link
Contributor

@tyrannosaurus-becks tyrannosaurus-becks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superb! Thank you, @edmeister !

@tyrannosaurus-becks tyrannosaurus-becks merged commit 5ffa5b5 into hashicorp:master May 7, 2019
@edmeister edmeister deleted the add_pki_config_urls branch May 8, 2019 17:30
dandandy pushed a commit to dandandy/terraform-provider-vault that referenced this pull request Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No ability to set PKI secret engines CRL
2 participants