Enable mount accessor export for vault_github_auth_backend #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
tyrannosaurus-becks
approved these changes
Mar 29, 2019
| if err != nil { | ||
| return fmt.Errorf("error reading github auth mount from '%q': %s", path, err) | ||
| } | ||
| log.Printf("[INFO] Read github auth mount from '%q'", path) |
There was a problem hiding this comment.
Minor thing I learned recently - if you use %q it automatically adds quotes surrounding the field. Check this out. This is in no way a blocker for the PR, just an interesting tidbit.
There was a problem hiding this comment.
Thanks, Becca. Really nice tip to know!
dandandy
pushed a commit
to dandandy/terraform-provider-vault
that referenced
this pull request
Jun 17, 2021
…nt-accessor Enable mount accessor export for vault_github_auth_backend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
accessorattribute forvault_github_auth_backendresource. This is useful to integrate an auth mount with resources such asvault_identity_entity_group_aliasandvault_identity_entity_alias.