Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vault_token resource #337

Merged
merged 5 commits into from
Mar 29, 2019
Merged

Add vault_token resource #337

merged 5 commits into from
Mar 29, 2019

Conversation

bhuisgen
Copy link
Contributor

@bhuisgen bhuisgen commented Mar 3, 2019

Reopen PR #157 without vault_token_role resource.

Signed-off-by: Boris HUISGEN <[email protected]>
Signed-off-by: Boris HUISGEN <[email protected]>
@bhuisgen bhuisgen changed the title Add vault token resource Add vault_token resource Mar 3, 2019
@3lpsy
Copy link

3lpsy commented Mar 18, 2019

Is there anything that needs to be done to get this PR merged?

@eidam
Copy link

eidam commented Mar 20, 2019

Is there anything that needs to be done to get this PR merged?

fix tests I guess as they are still referencing the vault_token_role resource

@matejvelikonja
Copy link

any chance of merging this PR? I would need this resource in the next project.

Copy link
Contributor

@tyrannosaurus-becks tyrannosaurus-becks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bhuisgen fantastic. Thank you!

@tyrannosaurus-becks tyrannosaurus-becks merged commit 472aa87 into hashicorp:master Mar 29, 2019
dandandy pushed a commit to dandandy/terraform-provider-vault that referenced this pull request Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants