Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cidr blocks ssh otp #331

Merged

Conversation

mbamber
Copy link
Contributor

@mbamber mbamber commented Feb 28, 2019

This adds support for specifying CIDR blocks when using the OTP key type.

Test output:

$ make testacc TESTARGS='-run=TestAccSSHSecretBackendRole*'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run=TestAccSSHSecretBackendRole* -timeout 120m
?   	github.com/terraform-providers/terraform-provider-vault	[no test files]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-vault/util	0.036s [no tests to run]
=== RUN   TestAccSSHSecretBackendRole_basic
--- PASS: TestAccSSHSecretBackendRole_basic (6.70s)
=== RUN   TestAccSSHSecretBackendRoleOTP_basic
--- PASS: TestAccSSHSecretBackendRoleOTP_basic (2.56s)
=== RUN   TestAccSSHSecretBackendRole_import
--- PASS: TestAccSSHSecretBackendRole_import (3.15s)
PASS
ok  	github.com/terraform-providers/terraform-provider-vault/vault	12.424s

Copy link
Contributor

@tyrannosaurus-becks tyrannosaurus-becks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thanks @mbamber !

@tyrannosaurus-becks tyrannosaurus-becks merged commit 07f7486 into hashicorp:master Mar 5, 2019
@mbamber mbamber deleted the add-cidr-blocks-ssh-otp branch April 1, 2019 07:41
dandandy pushed a commit to dandandy/terraform-provider-vault that referenced this pull request Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants