Fix some issues with updating fields for several resources #318
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to several PRs I made recently:
Fix incorrect field updating in
gcp_auth_backend_role
I made a mistake in setting the new
TypeBool
fields.GetOk
will returnwhether or not the key has been set to a non-zero value at some point
as the second value. If the value isfalse
, the second parameter will befalse
. Thus if a field was changed fromtrue
tofalse
, this will never be caught.Fix
d.Set
When using
d.Set
on aggregate types, they can potentially fail. See Terraform docs.I've updated some resources to check for these:
gcp_auth_backend_role
kubernetes_auth_backend_role
identity_group