Add vault_gcp_secret_roleset

[lawliet89]

To test this, we need to set GOOGLE_CREDENTIALS as a path to the JSON file containing GCP credentials, and GOOGLE_PROJECT as the name of the GCP project to run the tests against.

I have tested it locally and the test pass.

The bindings could have been passed to Vault as JSON, but it is currently bugged.

make testacc TESTARGS='-run=TestGCPSecretRoleset'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run=TestGCPSecretRoleset -timeout 120m
?   	github.com/terraform-providers/terraform-provider-vault	[no test files]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-vault/util	(cached) [no tests to run]
=== RUN   TestGCPSecretRoleset
--- PASS: TestGCPSecretRoleset (26.46s)
PASS
ok  	github.com/terraform-providers/terraform-provider-vault/vault	26.473s

[tyrannosaurus-becks]

Thanks @lawliet89 ! This looks great! Should we wait until hashicorp/vault-plugin-secrets-gcp#28 lands and then use project instead of service_account_project?

[lawliet89]

@tyrannosaurus-becks I've added code to handle both cases since that change might take a while to land in Vault and not everyone will upgrade right away.

[lawliet89]

Failure is due to unrelated TestDataSourcePolicyDocument

[tyrannosaurus-becks]

This looks fantastic! I merged master and found the tests pass. Thank you.

[fatmcgav]

@tyrannosaurus-becks Is there a feel for when 1.7.0 will be released that includes this really useful new resource?

Edit: Ignore that comment, I've just refreshed the repo and noticed that 1.7.0 was released yesterday!!! Sorry for the noise!