-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some issues with vault_identity_group
#301
Conversation
vault_identity_group
not updating policies while reading the resourcevault_identity_group
1865950
to
f3178f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lawliet89 thank you for working on this! Looks great!
One question - should there be any doc updates accompanying this?
The entire resource is undocumented. Is it ok for that to be done in a separate PR? |
That's done in #311 . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lawliet89 I saw and approved the docs PR. Thank you!
Fix some issues with `vault_identity_group`
policies
were not updated properly from reading the resource from Vaultpolicies
,member_group_ids
, andmember_entity_ids
to be ofschema.TypeSet
instead. These lists should contain unique items and the order should not matter when calculating the diffmember_entity_ids
for external groups (otherwise we get errors likeerror updating IdentityGroup "a6c92cfa-d0b0-8d61-7122-a59cf1123a45": cannot set 'member_entity_ids' on external groups
)Other fixes:
vault_identity_group_alias
Can't really write tests for the diff suppression without "logging in" with a real auth backend. It works in my local tests, though.
Before:
After: