jwt_auth_backend_role: add groups_claim_delimiter_pattern support #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
aromeyer
changed the title
| @@ -5,10 +5,6 @@ This plugin allows for JWTs (including OIDC tokens) to authenticate with Vault. | |||
|
|
|||
| **Please note**: We take Vault's security and our users' trust very seriously. If you believe you have found a security issue in Vault, _please responsibly disclose_ by contacting us at [[email protected]](mailto:[email protected]). | |||
|
|
|||
| ## IMPORTANT | |||
There was a problem hiding this comment.
I see changes to the vendored files, but I don't see any changes in vendor.json. Would it be possible revert the changes in vendor/, and then to update them (if needed) via Govendor instead? I'll add a note about that to our new contributing guide.
Otherwise this looks fantastic! Thank you!
There was a problem hiding this comment.
Hello,
as far I understand, now the "plugin" is going to use JSON pointer instead of using this additional parameter (hashicorp/vault-plugin-auth-jwt#24). I wait a bit to see what happen but I think that this PR will be soon useless.
Thanks for your comments.
aromeyer
force-pushed
the
aromeyer-jwt_auth_backend_role-add-groups_claim_delimiter_pattern-support
branch
from
37ec77c
to
23cbefa
Compare
tyrannosaurus-becks
approved these changes
Mar 29, 2019
dandandy
pushed a commit
to dandandy/terraform-provider-vault
that referenced
this pull request
Jun 17, 2021
…end_role-add-groups_claim_delimiter_pattern-support jwt_auth_backend_role: add groups_claim_delimiter_pattern support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for groups_claim_delimiter_pattern parameters within vault_jwt_auth_backend_role resource.
Sync version of vendor/github.com/hashicorp/vault-plugin-auth-jwt with https://github.com/hashicorp/vault-plugin-auth-jwt.