Add missing optional parameters to vault_cert_auth_backend_role #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
tyrannosaurus-becks
approved these changes
Jan 31, 2019
dandandy
pushed a commit
to dandandy/terraform-provider-vault
that referenced
this pull request
Jun 17, 2021
…ert-auth-method Add missing optional parameters to vault_cert_auth_backend_role
jseuren-exonet
added a commit
to jseuren-exonet/terraform-provider-vault
that referenced
this pull request
Aug 9, 2021
… vault_cert_auth_backend_role hashicorp#282 introduced many missing optional parameters in vault_cert_auth_backend_role, but missed validating and reading the `allowed_email_sans` field in the `certAuthResourceUpdate` and `certAuthResourceWrite` functions. Terraform currently correctly reads and plans for updating `allowed_email_sans`, but never actually does it. For example, locally I have defined a set of emails that are added to the `allowed_common_names` parameter and `allowed_email_sans`. Only `allowed_common_names` is created/updated. `allowed_email_sans` is not. ``` locals { allowed_emails = ['[email protected]', '[email protected]'] } resource "vault_cert_auth_backend_role" "employee-cert-auth" { # other stuff defined here allowed_common_names = locals.allowed_emails allowed_email_sans = locals.allowed_emails } ```
fairclothjm
pushed a commit
that referenced
this pull request
Sep 8, 2023
…ert_auth_backend_role (#1140) Add missing allowed_email_sans field to write and update functions of vault_cert_auth_backend_role #282 introduced many missing optional parameters in vault_cert_auth_backend_role, but missed validating and reading the `allowed_email_sans` field in the `certAuthResourceUpdate` and `certAuthResourceWrite` functions. Terraform currently correctly reads and plans for updating `allowed_email_sans`, but never actually does it. For example, locally I have defined a set of emails that are added to the `allowed_common_names` parameter and `allowed_email_sans`. Only `allowed_common_names` is created/updated. `allowed_email_sans` is not. ``` locals { allowed_emails = ['[email protected]', '[email protected]'] } resource "vault_cert_auth_backend_role" "employee-cert-auth" { # other stuff defined here allowed_common_names = locals.allowed_emails allowed_email_sans = locals.allowed_emails } ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I Added some parameters to
cert_auth_backend_role.allowed_common_namesallowed_dns_sansallowed_email_sansallowed_uri_sansallowed_organization_unitsbound_cidrsref: https://www.vaultproject.io/api/auth/cert/index.html#parameters