-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extra config options for auth_backend #245
Extra config options for auth_backend #245
Conversation
…e_ttl_seconds, listing_visibility & local paramaters
This is a nicely needed improvement! I'm working on a new auth_backend resource and I've noted a few points: IMO these auth backend resources need a bigger refactor, whereas the resource mounts/unmounts both the auth backend + configures its options. Adding these configuration options to the "generic" resource IMHO, if still proceeding this PR, these options should also be added to the |
@cvbarros I agree, probably the best option would be a resource per each mount type (aws, gcp, github, etc). The update (unmount/mount) part can be fixed using partial update and mount tune, similar to how it has been done in |
@tyrannosaurus-becks given the above, I'm happy to add a new resource specifically for aws instead of amending the generic one. What's your view on this? |
@martinssipenko @tyrannosaurus-becks @cvbarros - any chance you guys could also address the auth tune request here as well? See #234 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@martinssipenko @cvbarros I am flexible on the approach around whether to add these parameters per-mount-type or onto the generic backend. This code is good to go so I don't want to create more work over it. Let's use it!
@@ -95,9 +135,7 @@ func authBackendDelete(d *schema.ResourceData, meta interface{}) error { | |||
|
|||
log.Printf("[DEBUG] Deleting auth %s from Vault", path) | |||
|
|||
err := client.Sys().DisableAuth(path) | |||
|
|||
if err != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for noticing this and cleaning it up while you're at it.
Extra config options for auth_backend
Adds ability to configure following config parameters for
auth_backend
:default_lease_ttl_seconds
max_lease_ttl_seconds
listing_visibility
local
Test output:
Fixes #203