Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make gcp_secret_backend credentials optional #239

Merged
merged 2 commits into from
Dec 10, 2018

Conversation

Phylu
Copy link
Contributor

@Phylu Phylu commented Nov 10, 2018

This pull request changes the credentials option for the gcp_secret_backend from required to optional. It implements #238.

@ghost ghost added the size/XS label Nov 10, 2018
@Phylu
Copy link
Contributor Author

Phylu commented Nov 21, 2018

Is there any feedback regarding this pull request or the underlying issue. If any changes are needed for this PR to be accepted, I highly appreciate any comments.

Copy link
Contributor

@tyrannosaurus-becks tyrannosaurus-becks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Phylu this looks fantastic! Thank you!

@tyrannosaurus-becks tyrannosaurus-becks merged commit b839ca0 into hashicorp:master Dec 10, 2018
dandandy pushed a commit to dandandy/terraform-provider-vault that referenced this pull request Jun 17, 2021
Make gcp_secret_backend credentials optional
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants