Use set connection_url when available instead of value read for API response #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esponse The value in the API response will be masked if it contains credentials. This leads to the resource always appears to be out of sync
ghost
added
the
tyrannosaurus-becks
approved these changes
Nov 7, 2018
dandandy
pushed a commit
to dandandy/terraform-provider-vault
that referenced
this pull request
Jun 17, 2021
…ecret_backed_conn_connection_url Use set connection_url when available instead of value read for API response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #215. The value in the API response will be masked if it contains credentials. This leads to the resource always appears to be out of sync.
Fixes the following acceptance tests:
Note: TestAccDatabaseSecretBackendRole_import still fails, but not for
connect_urlmismatch anymore. I didn't have a chance to dig into the issues causing the current failures.