[gcp] Add new vault_gcp_secret_backend resource for managing GCP
#212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Secret backends [1] This requires an upstream change to Vault's `api.MountConfigInput` type which will be raised as a seperate PR. [1] https://www.vaultproject.io/docs/secrets/gcp/index.html
ghost
added
the
|
The tests pass as follows: |
…tion to the Vault API
There was a problem hiding this comment.
@fatmcgav this looks fantastic! Just a couple of very minor tweaks and I'll merge it in. Thanks for writing that test - I ran it and it passed.
vault/resource_gcp_secret_backend.go
Outdated
| }, | ||
| }) | ||
| if err != nil { | ||
| return fmt.Errorf("Error mounting to %q: %s", path, err) |
There was a problem hiding this comment.
Go prefers lower-cased error strings.
vault/resource_gcp_secret_backend.go
Outdated
| "credentials": credentials, | ||
| } | ||
| if _, err := client.Logical().Write(configPath, data); err != nil { | ||
| return fmt.Errorf("Error writing GCP configuration for %q: %s", path, err) |
There was a problem hiding this comment.
Lower case please. :-)
vault/resource_gcp_secret_backend.go
Outdated
|
|
||
| path := d.Id() | ||
|
|
||
| // TODO: Fill this out |
There was a problem hiding this comment.
Should this still be here?
vault/resource_gcp_secret_backend.go
Outdated
| log.Printf("[DEBUG] Checking if GCP backend exists at %q", path) | ||
| mounts, err := client.Sys().ListMounts() | ||
| if err != nil { | ||
| return true, fmt.Errorf("Error retrieving list of mounts: %s", err) |
|
Cheers for the review @tyrannosaurus-becks - All addressed :) |
tyrannosaurus-becks
approved these changes
Oct 30, 2018
fatmcgav
added a commit
to fatmcgav/terraform-provider-vault
that referenced
this pull request
Mar 15, 2019
Resource and docs was added via hashicorp#212, but I missed the sidebar addition...
This was referenced Mar 15, 2019
dandandy
pushed a commit
to dandandy/terraform-provider-vault
that referenced
this pull request
Jun 17, 2021
…_resource [gcp] Add new `vault_gcp_secret_backend` resource for managing GCP
dandandy
pushed a commit
to dandandy/terraform-provider-vault
that referenced
this pull request
Jun 17, 2021
Resource and docs was added via hashicorp#212, but I missed the sidebar addition...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Secret backends [1]
Add docs.
[1] https://www.vaultproject.io/docs/secrets/gcp/index.html