Adding GCP Auth backend resource #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
petems
force-pushed
the
add_gcp_auth_backend_resource
branch
3 times, most recently
from
b505866 to
9c8dd3f
Compare
petems
force-pushed
the
add_gcp_auth_backend_resource
branch
2 times, most recently
from
c8fcbd3 to
824205e
Compare
petems
force-pushed
the
add_gcp_auth_backend_resource
branch
2 times, most recently
from
3a9c994 to
172d778
Compare
There was a problem hiding this comment.
@petems this looks very good overall! The test is great, and it's passing. Just a couple of minor things and I'd be happy to merge it in.
petems
force-pushed
the
add_gcp_auth_backend_resource
branch
5 times, most recently
from
26761d4 to
6c9abad
Compare
* Allows configuration of credentials for backend
petems
force-pushed
the
add_gcp_auth_backend_resource
branch
from
6c9abad to
b767b03
Compare
tyrannosaurus-becks
approved these changes
Nov 9, 2018
dandandy
pushed a commit
to dandandy/terraform-provider-vault
that referenced
this pull request
Jun 17, 2021
…ource Adding GCP Auth backend resource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a largely a copy of the #99 backend config but for the GCP backend.
It only has 1 field, credentials. Probably needs more testing, I might need someone to pair with me on that 😄