-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bindpass
in vault_ldap_auth_backend
#184
Update bindpass
in vault_ldap_auth_backend
#184
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lawliet89 great catch, thanks for contributing this!
I'd wager that this change would cause the tests to fail because of how the field is checked here. Would you be willing to take a look at that?
Otherwise, it does look correct to me, and I'd be happy to merge it as soon as the related tests are confirmed as passing.
- Set the attribute to sensitive - Do not read back from the API since the API does not return it
f9b5134
to
b4d19be
Compare
Rebased from master Added |
13507a4
to
9e3e39e
Compare
947b158
to
925a5b4
Compare
925a5b4
to
718c73b
Compare
718c73b
to
1058798
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lawliet89 this looks fantastic. Thank you for doing this.
Update `bindpass` in `vault_ldap_auth_backend`
I am not sure if this is the right way to handle it. I tried to mimic how this is done in the
vault_aws_secret_backend
resource.