Update bindpass in vault_ldap_auth_backend
#184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
There was a problem hiding this comment.
@lawliet89 great catch, thanks for contributing this!
I'd wager that this change would cause the tests to fail because of how the field is checked here. Would you be willing to take a look at that?
Otherwise, it does look correct to me, and I'd be happy to merge it as soon as the related tests are confirmed as passing.
- Set the attribute to sensitive - Do not read back from the API since the API does not return it
lawliet89
force-pushed
the
ldap-auth-bindpass
branch
from
f9b5134
to
b4d19be
Compare
|
Rebased from master Added |
lawliet89
force-pushed
the
ldap-auth-bindpass
branch
from
13507a4
to
9e3e39e
Compare
lawliet89
force-pushed
the
ldap-auth-bindpass
branch
from
947b158
to
925a5b4
Compare
lawliet89
force-pushed
the
ldap-auth-bindpass
branch
from
925a5b4
to
718c73b
Compare
lawliet89
force-pushed
the
ldap-auth-bindpass
branch
from
718c73b
to
1058798
Compare
tyrannosaurus-becks
approved these changes
Sep 25, 2018
dandandy
pushed a commit
to dandandy/terraform-provider-vault
that referenced
this pull request
Jun 17, 2021
Update `bindpass` in `vault_ldap_auth_backend`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure if this is the right way to handle it. I tried to mimic how this is done in the
vault_aws_secret_backendresource.