vault_aws_auth_backend_role: Add bound_ec2_instance_id parameter #135
Conversation
There was a problem hiding this comment.
@JayH5 thank you for contributing this code! I appreciate it!
It looks good, but unfortunately the acceptance tests aren't passing. I checked and there are also a lot of failures on master, so it's hard to pick apart, and the code you've added probably isn't causing any of them.
I can't merge this though until I'm sure. It'll probably be at least a couple weeks before I can try to fix the tests.
If you get an itch, feel free to take a pass at it! I'm testing by:
- Running
$ vault server -devusing the Vault 0.11.1 binary - Setting
TF_ACC=1,VAULT_TOKEN=whatever, andVAULT_ADDR=http://localhost:8200 - Running the tests in
resource_aws_auth_backend_role_test.go
|
Actually, #153 may fix them, I'll play with it and see..... |
|
@JayH5 would you be willing to merge in master? Then I could re-run the tests and see where they're landing. If they're passing, happy to approve and merge. |
* Rework bound_ec2_instance_id to be a list type
ghost
added
the
|
@tyrannosaurus-becks thanks 🙏, I've merged master. |
…_instance_id vault_aws_auth_backend_role: Add bound_ec2_instance_id parameter
Fixes GH-134
I've left the parameter as a string instead of a list, so that the fix for GH-92 can come after this and handle all the bind parameters at once.