Add AppRole login #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a resource that manages AppRole auth backend logins and generating Vault tokens.
catsby
approved these changes
Dec 15, 2017
| resp = renewed | ||
| d.Set("lease_started", time.Now().Format(time.RFC3339)) | ||
| d.Set("client_token", resp.Auth.ClientToken) | ||
| d.SetId(resp.Auth.Accessor) |
There was a problem hiding this comment.
Does this resp.Auth.Accessor value change? It's unusual to see d.SetId outside of a create method
There was a problem hiding this comment.
It should be a permanent, stable ID, but I think I was just setting it just to be safe. I'll remove it.
There was a problem hiding this comment.
I spoke too soon, sorry. Yes, this value changes, because we're essentially replacing the resource. I'm trading in one token (that has expired) for a new token (that has not). I dunno if it's cool to play around with resource IDs like that, but this resource is of minimal utility if I can't swap out the tokens. :/
There was a problem hiding this comment.
It's unusual to swap them, yes, but the circumstances seem to warrant it
dandandy
pushed a commit
to dandandy/terraform-provider-vault
that referenced
this pull request
Jun 17, 2021
…e_auth_backend_login Add AppRole login
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a resource that manages AppRole auth backend logins and generating
Vault tokens.
Note: this PR depends on #31.