Add support for AppRole SecretIDs #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow users to generate and manage AppRole SecretIDs. Depends on #30.
Merged
catsby
approved these changes
Dec 15, 2017
| Sensitive: true, | ||
| }, | ||
|
|
||
| "cidr_list": { |
There was a problem hiding this comment.
Is sort/ordering relevant here?
|
|
||
| d.Set("backend", backend) | ||
| d.Set("role_name", role) | ||
| d.Set("cidr_list", cidrs) |
There was a problem hiding this comment.
check error from setting non-scalar value please
Make cidr_list a set, because we're not necessarily guaranteed an order. Check the error when setting complex types in state.
|
Think I've addressed all the feedback here. Still look good? |
tyrannosaurus-becks
deleted the
paddy_approle_auth_backend_role_secret_id
branch
dandandy
pushed a commit
to dandandy/terraform-provider-vault
that referenced
this pull request
Jun 17, 2021
…e_auth_backend_role_secret_id Add support for AppRole SecretIDs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to generate and manage AppRole SecretIDs.
Depends on #30.