Add AWS Auth Backend client. #19
Conversation
This allows us to configure the client that Vault uses when making requests on behalf of the AWS Auth backend. See https://www.vaultproject.io/api/auth/aws/index.html#configure-client for more info.
The destroy check used to check for all mounts that had an auth backend configured, not just those controlled by the test. That's not what we want to do, so this updated version just checks for configurations created by the test.
| } | ||
| log.Printf("[DEBUG] Wrote AWS auth backend client config to %q", "auth/"+backend+"/config/client") | ||
|
|
||
| d.SetId("auth/" + backend + "/config/client") |
There was a problem hiding this comment.
Probably want "auth/" + backend + "/config/client" to come from a convenience method at this point, it's hard-coded in 4 spots just right here 😄
|
|
||
| # vault\_aws\_auth\_backend\_client | ||
|
|
||
| Configures the client used by an AWS Auth Backend in Vault. |
There was a problem hiding this comment.
Nit: is it helpful to say the HTTP client here? 🤔
There was a problem hiding this comment.
Opinion: The Vault docs never reference it as an HTTP client, so I think it's better without. But am open to changing it if you feel strongly one way or another.
There was a problem hiding this comment.
I'm not super-familiar with what's going on behind the scenes here, but I suggest generally that we try to use the same terminology used in the Vault documentation so it's easier for users to understand how these things relate. If Vault is considering HTTP to be an implementation detail here, then it seems right for us to do that too.
Add a helper function that builds the path to the client config for us.
|
Think I responded to all the feedback. Good to merge @catsby? (I know you gave it a LGTM, but new code and a response to your question makes me want to just doublecheck.) |
…ient_auth Add AWS Auth Backend client.
Resolves Dependabot alert hashicorp#19
This allows us to configure the client that Vault uses when making
requests on behalf of the AWS Auth backend. See
https://www.vaultproject.io/api/auth/aws/index.html#configure-client
for more info.