Make policies importable. #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes policies importable. Minor changes were needed for this: * Read now sets name, in addition to policy. * We added the Importer functionality and a test for it. * Our test config needed to be updated to allow the policy name to be injected, to help ensure uniqueness across runs.
|
Test failure is an acctest vendoring failure. Should be resolved by #12. |
catsby
reviewed
Aug 28, 2017
| ) | ||
|
|
||
| func TestAccPolicy_importBasic(t *testing.T) { | ||
| name := "test-" + acctest.RandString(10) |
There was a problem hiding this comment.
There's also RandomWithPrefix, if integers are valid in the name.
| @@ -77,6 +80,7 @@ func policyRead(d *schema.ResourceData, meta interface{}) error { | |||
| } | |||
|
|
|||
| d.Set("policy", policy) | |||
| d.Set("name", name) | |||
There was a problem hiding this comment.
Should we set this in the CREATE method, policyWrite? Right now, policyWrite does not call policyRead, so the name attribute won't be set until a refresh operation happens.
Normally we call create and it returns read. If that's not necessary here, I recommend we set name in policyWrite then.
There was a problem hiding this comment.
Good call, I missed that wasn't happening here. Updated to now call policyRead from policyWrite.
Make sure to read the new policy values out of vault after updating.
dandandy
pushed a commit
to dandandy/terraform-provider-vault
that referenced
this pull request
Jun 17, 2021
…_policy Make policies importable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes policies importable. Minor changes were needed for this:
injected, to help ensure uniqueness across runs.