This repository has been archived by the owner on Nov 14, 2020. It is now read-only.
Add more shovel parameters #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add-forward-headers, delete-after, prefetch-count
ghost
added
|
ping @cyrilgdn :-) |
|
@cyrilgdn There are several people waiting on this PR. Could you please review it? Many thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
as promised :-) I prepared a pull request to update the shovel resource. It passes all tests and works in our environment.
With this update it is possible to use all available parameters for dynamic shovels. For this to work I also sent a patch to rabbit-hole which was merged and is available since v2.3.0.
As the provider currently supports some deprecated parameters that do not show up anymore in the RabbitMQ documentation I followed https://www.terraform.io/docs/extend/best-practices/deprecations.html#renaming-an-optional-attribute and added Deprecated/ConflictsWith and warnings to the docs. If I understand it correctly, best practice would be to release (at least?) one minor release of the provider before removing those deprecated parameters completely.
Please let me know if the patches are fine (I am not a developer ...) - any feedback is highly appreciated.
Thanks & Cheers,
Andreas