-
Notifications
You must be signed in to change notification settings - Fork 79
Adding client certificate authentication #29
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @samueldumont ,
Thanks for your work on this and sorry for the response delay.
The code looks good to me 👍 , I'll trust you on the fact that it works as it's not very easy to test 😄
Could you just remove the .version
and build.sh
files as we don't need them (you can add them in your gitignore file if you want to keep them for your own purpose).
Hi @cyrilgdn ! Thanks a lot, it works perfectly fine indeed, we used my fork for a year with no issues ;) I'm glad this can go back to the main provider so we don't have to mess anymore with custom providers. I removed the files so it should be good now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samueldumont Perfect, thanks !
And sorry again for the delay, there were no more active maintainer on this provider and it took me a bit of time to go through opened issues/PRs since I've been added as a maintainer.
I'll let you know here when it's released.
@samueldumont FYI, this has just been released in v1.4.0. |
Thank you very much ! |
Hi,
For my own project, I need to be able to use client certificate authentication. This change is working well, altough not supporting (yet) passphrase protected keys.
This could also be implemented, I can do it if needed https://medium.com/@prateeknischal25/using-encrypted-private-keys-with-golang-server-379919955854
I'm not the only one needing this : fix #24 . I think it would be good for the official provider to support it.
Regards,
Samuel