Fix bindings not being saved to state. #8
Conversation
…mq after creating a binding
There was a problem hiding this comment.
@sgarlick987 Thanks for putting this together. I've made a few comments. Let me know if you have any questions or if something I suggested is not correct.
rabbitmq/resource_binding.go
Outdated
| "github.com/hashicorp/terraform/helper/schema" | ||
| "github.com/michaelklishin/rabbit-hole" | ||
| "net/url" |
There was a problem hiding this comment.
nit: net/url should be inbetween log and strings.
There was a problem hiding this comment.
Sure, for some reason intellij reorged it to the bottom like that, just alpha order is expected?
There was a problem hiding this comment.
Ordering is usually something like: first standard packages, blank space, external packages. See the other files for an example.
rabbitmq/resource_binding.go
Outdated
| Type: schema.TypeString, | ||
| Required: true, | ||
| ForceNew: true, | ||
| }, |
There was a problem hiding this comment.
Rather than removing properties_key entirely, it should be converted into a read-only computed parameter:
"properties_key": &schema.Schema{
Type: schema.TypeString,
Computed: true,
},There was a problem hiding this comment.
Will do, thanks for the tip.
| @@ -72,8 +71,6 @@ The following arguments are supported: | |||
|
|
|||
| * `destination_type` - (Required) The type of destination (queue or exchange). | |||
|
|
|||
| * `properties_key` - (Required) A unique key to refer to the binding. | |||
There was a problem hiding this comment.
Instead of being removed, this should be moved to the Attribute Reference section and listed as an exported attribute.
|
This looks good. Thank you again for not just digging into the cause of this issue but putting a fix together for it :) |
This should fix #2 see explanation there for the issue.
Tests ran/passed. I also tested it against our corp env and looks like things are saving properly now.