This repository has been archived by the owner on Nov 14, 2020. It is now read-only.
Travis: Execute acceptance tests on dockerized RMQ. #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
multani
suggested changes
Jan 7, 2020
.travis.yml
Outdated
| @@ -17,13 +28,18 @@ script: | |||
| - make test | |||
| - make vet | |||
| - make website-test | |||
| - docker-compose -f $(pwd)/scripts/docker-compose.yml up -d | |||
| - $(pwd)/scripts/wait-rabbitmq-docker.sh $(pwd)/scripts/docker-compose.yml | |||
There was a problem hiding this comment.
You are passing the docker-compose file but it's not really used inside the script, I guess you can remove it?
There was a problem hiding this comment.
Indeed 👍 , a bit copy/pasted from another provider where it was used 😅
| rabbitmq: | ||
| image: rabbitmq:${RABBITMQ_VERSION:-3.8}-management-alpine | ||
| ports: | ||
| - 15672:15672 |
There was a problem hiding this comment.
To make things more explicit, could you also pass the environment variables that you defined for the username, password in here?
env:
RABBITMQ_DEFAULT_USER: ${RABBITMQ_USERNAME:guest}
RABBITMQ_DEFAULT_PASS: ${RABBITMQ_PASSWORD:guest}
|
Thanks @multani for your review ! I updated the PR based on your remarks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.