Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placement policy support for Compute Instance #6125

Conversation

modular-magician
Copy link
Collaborator

Revert my last commit that reverted the placement policy for compute instance addition. Thanks Git!

This reverts commit 18d6446.

See GoogleCloudPlatform/magic-modules#3217 for previous PR that was reverted due to quota issues in CI testing

Release Note Template for Downstream PRs (will be copied)

compute: Added support for `google_compute_resource_policy` group placement policies
compute: Added support for `google_compute_instance` `resource_policies` field

Derived from GoogleCloudPlatform/magic-modules#3256

* Revert "Revert "Placement policy support for Compute Instance (hashicorp#3217)" (hashicorp#3250)"

This reverts commit 18d6446.

* Auto restart false, us central a

* Create two instances during collocate test

* Add note on collocation and vm_count

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 42146ae into hashicorp:master Apr 15, 2020
@ghost
Copy link

ghost commented May 16, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators May 16, 2020
@modular-magician modular-magician deleted the downstream-pr-7c201f5e79eac7eff911eea8dd84eb04f91a199f branch November 16, 2024 23:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant