Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

candidate subnets ignore read, admin enabled computed #6046

Conversation

modular-magician
Copy link
Collaborator

Candidate subnets does not return from API
Fixes: #5982

Admin enabled default to true and send empty value. Enables update for admin_enabled
Fixes: #5965

Release Note Template for Downstream PRs (will be copied)

`compute`: Fixed perma-diff on `google_compute_interconnect_attachment` `candidate_subnets`
`compute`: Fixed diff on default value for `google_compute_interconnect_attachment` `admin_enabled`
`compute`: Added update support for `google_compute_interconnect_attachment` `admin_enabled`

Derived from GoogleCloudPlatform/magic-modules#3342

* candidate subnets ignore read, admin enabled computed

* Make adminEnabled updatable and send empty value

* Default adminEnabled to true

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 6f85fa8 into hashicorp:master Apr 3, 2020
@ghost
Copy link

ghost commented May 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators May 4, 2020
@modular-magician modular-magician deleted the downstream-pr-19298625bef3dc9900452e314f895c79031f10e4 branch November 17, 2024 01:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
1 participant