Add google_logging_folder_sink resource #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosbo
reviewed
Sep 27, 2017
rosbo
reviewed
Sep 27, 2017
| } | ||
| } | ||
| if sink.IncludeChildren != includeChildren { | ||
| return fmt.Errorf("mismatch on include_children: api has %s but client has %s", sink.IncludeChildren, attributes["include_children"]) |
There was a problem hiding this comment.
go vet fails because you are coercing a bool to a string. Use %t
There was a problem hiding this comment.
Fixed, went with %v (and the correct variable this time)
rosbo
reviewed
Sep 27, 2017
| func resourceLoggingFolderSinkCreate(d *schema.ResourceData, meta interface{}) error { | ||
| config := meta.(*Config) | ||
|
|
||
| folder := d.Get("folder").(string) |
selmanj
changed the title
|
Haha whoops yeah that name was bad, sorry cold medicine is making me terse |
rosbo
approved these changes
Oct 2, 2017
negz
pushed a commit
to negz/terraform-provider-google
that referenced
this pull request
Oct 17, 2017
* Fix bad page title * Add resource logging_folder_sink * Use proper parse function and string format * Remove unused strings
negz
pushed a commit
to negz/terraform-provider-google
that referenced
this pull request
Oct 17, 2017
* Fix bad page title * Add resource logging_folder_sink * Use proper parse function and string format * Remove unused strings
chrisst
pushed a commit
to chrisst/terraform-provider-google
that referenced
this pull request
Nov 9, 2018
* Fix bad page title * Add resource logging_folder_sink * Use proper parse function and string format * Remove unused strings
luis-silva
pushed a commit
to luis-silva/terraform-provider-google
that referenced
this pull request
May 21, 2019
Signed-off-by: Modular Magician <[email protected]>
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also snuck in a minor page title fix relating to
google_logging_billing_account_sinksorry