Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

give disk_autoresize a default in google_sql_database_instance #806

Merged
merged 1 commit into from
Nov 29, 2017

Conversation

danawillow
Copy link
Contributor

Fixes #614.

Disk auto-resize defaults to true server-side for all gen 2 SQL instances. Currently, we attempt to use that default by setting the field to computed, but then we override it in the create function by setting ForceSendFields for the value, which will be false if unset. We can't get rid of the ForceSendFields since people need to be allowed to set the value to be false, but since the API doesn't complain when setting StorageAutoResize for gen 1 instances, we can just have a default.

=== RUN   TestAccGoogleSqlDatabaseInstance_importBasic
=== RUN   TestAccGoogleSqlDatabaseInstance_importBasic3
=== RUN   TestAccGoogleSqlDatabaseInstance_basic
=== RUN   TestAccGoogleSqlDatabaseInstance_basic2
=== RUN   TestAccGoogleSqlDatabaseInstance_basic3
=== RUN   TestAccGoogleSqlDatabaseInstance_dontDeleteDefaultUserOnReplica
=== RUN   TestAccGoogleSqlDatabaseInstance_settings_basic
=== RUN   TestAccGoogleSqlDatabaseInstance_slave
=== RUN   TestAccGoogleSqlDatabaseInstance_diskspecs
=== RUN   TestAccGoogleSqlDatabaseInstance_maintenance
=== RUN   TestAccGoogleSqlDatabaseInstance_settings_upgrade
=== RUN   TestAccGoogleSqlDatabaseInstance_settings_downgrade
=== RUN   TestAccGoogleSqlDatabaseInstance_authNets
=== RUN   TestAccGoogleSqlDatabaseInstance_multipleOperations
--- PASS: TestAccGoogleSqlDatabaseInstance_settings_upgrade (59.27s)
--- PASS: TestAccGoogleSqlDatabaseInstance_importBasic (62.89s)
--- PASS: TestAccGoogleSqlDatabaseInstance_authNets (76.98s)
--- PASS: TestAccGoogleSqlDatabaseInstance_multipleOperations (89.80s)
--- PASS: TestAccGoogleSqlDatabaseInstance_diskspecs (450.95s)
--- PASS: TestAccGoogleSqlDatabaseInstance_basic3 (399.64s)
--- PASS: TestAccGoogleSqlDatabaseInstance_settings_basic (41.65s)
--- PASS: TestAccGoogleSqlDatabaseInstance_maintenance (441.24s)
--- PASS: TestAccGoogleSqlDatabaseInstance_basic (50.68s)
--- PASS: TestAccGoogleSqlDatabaseInstance_basic2 (52.45s)
--- PASS: TestAccGoogleSqlDatabaseInstance_settings_downgrade (49.19s)
--- PASS: TestAccGoogleSqlDatabaseInstance_slave (933.03s)
--- PASS: TestAccGoogleSqlDatabaseInstance_importBasic3 (429.28s)
--- PASS: TestAccGoogleSqlDatabaseInstance_dontDeleteDefaultUserOnReplica (707.19s)

@danawillow danawillow requested a review from rosbo November 29, 2017 23:31
@danawillow danawillow merged commit 0ef0367 into hashicorp:master Nov 29, 2017
@danawillow danawillow deleted the is-614 branch November 29, 2017 23:51
modular-magician added a commit to modular-magician/terraform-provider-google that referenced this pull request Sep 27, 2019
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disk autoresize defaults to false for Postgres
2 participants