Add support to google_compute_target_pool for health checks self_link #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ealth check self_link
TF_ACC=1 go test ./google -v -run TestAccComputeTargetPool_basic -timeout 120m
=== RUN TestAccComputeTargetPool_basic
--- PASS: TestAccComputeTargetPool_basic (72.02s)
PASS |
danawillow
approved these changes
Nov 8, 2017
|
|
||
| hcLink := healthCheckRes.Primary.Attributes["self_link"] | ||
| if targetPoolRes.Primary.Attributes["health_checks.0"] != hcLink { | ||
| return fmt.Errorf("Health check not set up. Expected '%s'", hcLink) |
There was a problem hiding this comment.
fyi: '%s' is equivalent to %q (up to you if you want to change it)
chrisst
pushed a commit
to chrisst/terraform-provider-google
that referenced
this pull request
Nov 9, 2018
…hashicorp#702) - Accepts self_link in addition of health check name - Removes the need for an API call to generate the self link - Improves the documentation to mention that only the legacy google_compute_http_health_check is supported. This will prevent our user from being stuck like mentioned here: hashicorp#300. - Adds a MaxItems:1 in the schema. You can't have more than one. The API will fail. The official docs also says so. - Adds a check to the acceptance test to ensure the health checks are properly setup.
luis-silva
pushed a commit
to luis-silva/terraform-provider-google
that referenced
this pull request
May 21, 2019
Signed-off-by: Modular Magician <[email protected]>
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of requiring the health check name. It now accepts the self_link or the name.
I added:
google_compute_http_health_checkis supported. This will prevent our user from being stuck like mentioned here: Update compute_health_check.html.markdown #300.MaxItems:1in the schema. You can't have more than one. The API will fail. The official docs also says so.