Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add import support to global forwarding rule #653

Merged
merged 2 commits into from
Oct 31, 2017

Conversation

rosbo
Copy link
Contributor

@rosbo rosbo commented Oct 30, 2017

Fixes #643

TF_ACC=1 go test ./google -v -run TestAccComputeGlobalForwardingRule_ -timeout 120m
=== RUN   TestAccComputeGlobalForwardingRule_import
=== RUN   TestAccComputeGlobalForwardingRule_basic
=== RUN   TestAccComputeGlobalForwardingRule_update
=== RUN   TestAccComputeGlobalForwardingRule_ipv6
=== RUN   TestAccComputeGlobalForwardingRule_labels
--- PASS: TestAccComputeGlobalForwardingRule_ipv6 (111.14s)
--- PASS: TestAccComputeGlobalForwardingRule_basic (111.16s)
--- PASS: TestAccComputeGlobalForwardingRule_import (111.83s)
--- PASS: TestAccComputeGlobalForwardingRule_update (124.67s)
--- PASS: TestAccComputeGlobalForwardingRule_labels (135.41s)
PASS

cc/ @siulcode

@rosbo rosbo requested a review from danawillow October 30, 2017 22:14
@rosbo rosbo merged commit 0332208 into hashicorp:master Oct 31, 2017
@rosbo rosbo deleted the global-forwarding-rule-import-support branch October 31, 2017 18:28
chrisst pushed a commit to chrisst/terraform-provider-google that referenced this pull request Nov 9, 2018
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
flozzone pushed a commit to flozzone/terraform-provider-google that referenced this pull request Oct 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No import support for google_compute_global_forwarding_rule? DR setup for Global LB
2 participants