Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add labels to google_storage_bucket #652

Merged
merged 5 commits into from
Oct 30, 2017
Merged

Add labels to google_storage_bucket #652

merged 5 commits into from
Oct 30, 2017

Conversation

danawillow
Copy link
Contributor

Fixes #599.

$ make testacc TEST=./google TESTARGS='-run=TestAccStorageBucket_labels'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./google -v -run=TestAccStorageBucket_labels -timeout 120m
=== RUN   TestAccStorageBucket_labels
--- PASS: TestAccStorageBucket_labels (6.83s)
PASS
ok  	github.com/terraform-providers/terraform-provider-google/google	6.993s

The extra vendor changes are in here because of some cascading dependencies (storage and bigquery both depend on gensupport).

@danawillow danawillow requested a review from rosbo October 30, 2017 21:54
rosbo
rosbo approved these changes Oct 30, 2017
View reviewed changes
Copy link
Contributor

@rosbo rosbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. One more resource supporting labels! :)

vendor/vendor.json
@@ -964,10 +964,10 @@
"revisionTime": "2016-12-14T09:25:55Z"
},
{
"checksumSHA1": "FEzQdhqmb6aqGL1lKnjOcUHIGSY=",
"checksumSHA1": "jhyv7qysp0NZbWzAaUCsKATDGuk=",
"path": "google.golang.org/api/bigquery/v2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is updating bigquery client to the latest version related to this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I updated storage, it didn't build because it relied on a version of gensupport later than what we currently had vendored. When I updated gensupport, it still didn't build because bigquery was relying on an older version of gensupport.

@danawillow danawillow merged commit 7b69c31 into hashicorp:master Oct 30, 2017
@danawillow danawillow deleted the is-599 branch October 30, 2017 22:48
chrisst pushed a commit to chrisst/terraform-provider-google that referenced this pull request Nov 9, 2018
@danawillow
Add labels to google_storage_bucket (hashicorp#652)
d09f179 
* revendor storage

* revendor gensupport

* revendor bigquery

* add support for storage bucket labels

* bucket label docs
luis-silva pushed a commit to luis-silva/terraform-provider-google that referenced this pull request May 21, 2019
@modular-magician @chrisst
Allow default disk size for TestAccComputeAttachedDisk_region (hashic…
cab890c 
…orp#652)

<!-- This change is generated by MagicModules. -->
Original Author: @chrisst
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rosbo rosbo rosbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add label creation to storage bucket resource type
2 participants
@danawillow @rosbo