-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for setting labels to google_project
#383
Add support for setting labels to google_project
#383
Conversation
google_project
4854e42
to
ba7e2cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks straightforward!
The test code is a little bit more complex than we normally write it (we tend to write hardcoded keys in a config file and static error messages), but I like how readable it makes the tests!
Will merge once I can verify integration tests pass. Thanks so much for the PR!
@selmanj any new on this? |
Acceptance tests are passing. TF_ACC=1 go test ./google -v -run TestAccGoogleProject_ -timeout 120m
=== RUN TestAccGoogleProject_importBasic
--- PASS: TestAccGoogleProject_importBasic (19.04s)
=== RUN TestAccGoogleProject_create
--- PASS: TestAccGoogleProject_create (17.68s)
=== RUN TestAccGoogleProject_createBilling
--- PASS: TestAccGoogleProject_createBilling (20.45s)
=== RUN TestAccGoogleProject_createLabels
--- PASS: TestAccGoogleProject_createLabels (16.28s)
=== RUN TestAccGoogleProject_merge
--- PASS: TestAccGoogleProject_merge (25.11s)
=== RUN TestAccGoogleProject_updateLabels
--- PASS: TestAccGoogleProject_updateLabels (25.27s)
PASS
ok github.com/terraform-providers/terraform-provider-google/google 103.523s |
Thanks @rnaveiras, sorry for the delay! |
<!-- This change is generated by MagicModules. --> /cc @chrisst
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
This PR adds support for labels in the
google_project
resource.e.g.
Acceptance Tests