google_compute_network_peering: import/export custom routes

[leg100]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

google_compute_network_peering is missing beta features, in particular:

(from gcloud beta compute networks peerings create --help)

     --export-custom-routes
        If set, the network will export custom routes to peer network. Use
        --no-export-custom-routes to disable it.

     --import-custom-routes
        If set, the network will import custom routes from peer network. Use
        --no-import-custom-routes to disable it.

New or Affected Resource(s)

• google_compute_network_peering

Potential Terraform Configuration

resource "google_compute_network_peering" "peering" {
  provider = "google-beta"
  name         = "peering"
  network      = "${var.source_net}",
  peer_network = "${var.dest_net}",
  export_custom_routes = "true"
  import_custom_routes = "true"
}

Both parameters should default to false if omitted.

References

• #0000

[marcohelmerich]

I created a pull request in the magic modules repositry, but may need some help with testing.
GoogleCloudPlatform/magic-modules#1695

[nesl247]

It looks like that PR was merged in. Not being familiar with terraform, what has to happen next?

[rileykarson]

Looks like this made it into 2.8.0: https://github.com/terraform-providers/terraform-provider-google/blob/master/CHANGELOG.md#280-june-04-2019

We missed adding the docs though, unfortunately. I filed #4097 to track that, I'm going to close this issue out since the actual feature has been added.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!