Allow upgrading GKE versions and provide better error message handling #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whoops, forgot that I already had a PR in this branch. This is now the full fix. Updating description. |
danawillow
changed the title
rosbo
approved these changes
Aug 7, 2017
google/resource_container_cluster.go
Outdated
| return waitErr | ||
| } | ||
|
|
||
| log.Printf("[INFO] GKE cluster %s has been updated to %s", d.Id(), |
There was a problem hiding this comment.
Consider adding a similar log statement after the node version update.
There was a problem hiding this comment.
There already was one, so I changed them a bit to differentiate between the master and node upgrades
z1nkum
pushed a commit
to z1nkum/terraform-provider-google
that referenced
this pull request
Aug 15, 2017
hashicorp#291) * Better error handling for GKE operations * Handle GKE version upgrades * clarify log message
negz
pushed a commit
to negz/terraform-provider-google
that referenced
this pull request
Oct 17, 2017
hashicorp#291) * Better error handling for GKE operations * Handle GKE version upgrades * clarify log message
luis-silva
pushed a commit
to luis-silva/terraform-provider-google
that referenced
this pull request
May 21, 2019
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a GKE operation fails, it doesn't actually populate the error return value. Instead, it sets StatusMessage to some value (see https://cloud.google.com/container-engine/reference/rest/v1/projects.zones.operations). If
statusMessageis set, we know an error has occurred.The error message that was getting hidden in #223 was that you can't upgrade a node past the master version. This fix upgrades the master and then the node upon update. If it seems useful in the future, we can separate node/master version fields.
Fixes #223.