Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add defaultPartitionExpirationMs field to google_bigquery_dataset resource #2287

Conversation

amatellanes
Copy link
Contributor

@amatellanes amatellanes commented Oct 19, 2018

tpoindessous and others added 2 commits October 17, 2018 14:35
Create a link to storage_bucket_acl ressource documentation page.

It's easier than scrolling and scrolling or copy text and search it on the page.

Thank you !
@ghost ghost added the size/s label Oct 19, 2018
@rileykarson rileykarson self-assigned this Nov 13, 2018
@rileykarson rileykarson self-requested a review November 13, 2018 00:08
@rileykarson rileykarson changed the base branch from master to 2.0.0 November 13, 2018 16:09
@rileykarson
Copy link
Collaborator

Huh! Looks like changing the base on this and #2288 added some other commit. Weird! I didn't think that would be a history-altering action, my apologies.

Copy link
Collaborator

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @amatellanes! I'll duplicate these changes into Magic Modules and merge this PR along with the MM-generated google-beta PR.

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants