Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support import for google_compute_subnetwork #227

Merged
merged 1 commit into from
Jul 26, 2017
Merged

Support import for google_compute_subnetwork #227

merged 1 commit into from
Jul 26, 2017

Conversation

rosbo
Copy link
Contributor

@rosbo rosbo commented Jul 20, 2017

issue #182

cc/ @danawillow

@rosbo rosbo requested a review from danawillow July 24, 2017 23:41
@rosbo rosbo force-pushed the import_compute_subnetwork branch from c50028f to 1184daf Compare July 25, 2017 00:24
@danawillow
Copy link
Contributor 

$ make testacc TEST=./google TESTARGS='-run=TestAccComputeSubnetwork'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./google -v -run=TestAccComputeSubnetwork -timeout 120m
=== RUN   TestAccComputeSubnetwork_importBasic
--- PASS: TestAccComputeSubnetwork_importBasic (60.76s)
=== RUN   TestAccComputeSubnetwork_basic
--- PASS: TestAccComputeSubnetwork_basic (66.00s)
=== RUN   TestAccComputeSubnetwork_update
--- PASS: TestAccComputeSubnetwork_update (77.40s)
PASS
ok  	github.com/terraform-providers/terraform-provider-google/google	204.298s

👍 , merge at will.

@rosbo rosbo merged commit 01ef451 into hashicorp:master Jul 26, 2017
z1nkum pushed a commit to z1nkum/terraform-provider-google that referenced this pull request Aug 15, 2017
@rosbo
Support import for google_compute_subnetwork (hashicorp#227)
c18e331
negz pushed a commit to negz/terraform-provider-google that referenced this pull request Oct 17, 2017
@rosbo
Support import for google_compute_subnetwork (hashicorp#227)
3b2edc0
chrisst pushed a commit to chrisst/terraform-provider-google that referenced this pull request Nov 9, 2018
@rosbo
Support import for google_compute_subnetwork (hashicorp#227)
dff998e
luis-silva pushed a commit to luis-silva/terraform-provider-google that referenced this pull request May 21, 2019
@modular-magician @chrisst
Make the default timout 5 minutes when timeout is 0 (hashicorp#227)
881cd1a 
<!-- This change is generated by MagicModules. -->
/cc @chrisst
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danawillow danawillow Awaiting requested review from danawillow

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rosbo @danawillow