Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding attribute family for bigtable_table #2228

Merged
merged 6 commits into from
Oct 12, 2018
Merged

adding attribute family for bigtable_table #2228

merged 6 commits into from
Oct 12, 2018

Conversation

eraac
Copy link
Contributor

@eraac eraac commented Oct 11, 2018

Fix #1576

make testacc TESTARGS='-run=TestAccBigtableTable'

==> Checking that code complies with gofmt requirements...
TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test $(go list ./... |grep -v 'vendor') -v -run=TestAccBigtableTable -timeout 120m
?   	github.com/terraform-providers/terraform-provider-google	[no test files]
=== RUN   TestAccBigtableTable_basic
=== PAUSE TestAccBigtableTable_basic
=== RUN   TestAccBigtableTable_splitKeys
=== PAUSE TestAccBigtableTable_splitKeys
=== RUN   TestAccBigtableTable_family
=== PAUSE TestAccBigtableTable_family
=== CONT  TestAccBigtableTable_basic
=== CONT  TestAccBigtableTable_family
=== CONT  TestAccBigtableTable_splitKeys
--- PASS: TestAccBigtableTable_splitKeys (16.90s)
--- PASS: TestAccBigtableTable_basic (17.84s)
--- PASS: TestAccBigtableTable_family (19.11s)
PASS
ok  	github.com/terraform-providers/terraform-provider-google/google	19.154s
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-google/scripts	(cached) [no tests to run]

@ghost ghost added the size/s label Oct 11, 2018
@rileykarson rileykarson self-requested a review October 11, 2018 15:00
Copy link
Collaborator

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I have an ask about how we represent the field in schema - I think we might want to support an additional field in the future and we can save ourselves from a breaking change later by shaping the schema a little differently now.

google/resource_bigtable_table.go Outdated Show resolved Hide resolved
@ghost ghost added size/m and removed size/s labels Oct 11, 2018
@eraac
Copy link
Contributor Author

eraac commented Oct 11, 2018

@rileykarson I have push new code - updating code, documentation and test. Thanks for the feedback!

Not 100% sure about the code, waiting for a review

Copy link
Collaborator

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a couple more small comments.

google/resource_bigtable_table.go Outdated Show resolved Hide resolved
google/resource_bigtable_table_test.go Show resolved Hide resolved
website/docs/r/bigtable_table.html.markdown Outdated Show resolved Hide resolved
Copy link
Collaborator

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!

@rileykarson rileykarson merged commit ea11a8e into hashicorp:2.0.0 Oct 12, 2018
chrisst pushed a commit to chrisst/terraform-provider-google that referenced this pull request Nov 12, 2018
@ghost
Copy link

ghost commented Nov 16, 2018

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants