Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cloudbuild trigger in place #2121

Merged
merged 2 commits into from
Nov 12, 2018

Conversation

nownabe
Copy link
Contributor

@nownabe nownabe commented Sep 27, 2018

Hi!

Now any changes of cloud build trigger create new one, this PR makes triggers modifiable in place.

I referred to bigquery dataset. If theare are better examples, I'd like to know them.

Copy link
Collaborator

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I'm going to wait on Magic Modules to output it's downstream, then merge this one instead of it.

@rileykarson rileykarson merged commit 02eb26b into hashicorp:master Nov 12, 2018
rileykarson pushed a commit to rileykarson/terraform-provider-google that referenced this pull request Nov 12, 2018
Hi!

Now any changes of cloud build trigger create new one, this PR makes triggers modifiable in place.

I referred to [bigquery dataset](https://github.com/terraform-providers/terraform-provider-google/blob/9f0b792f091ce1a27f718d23184a481d6b20ec05/google/resource_bigquery_dataset.go#L353). If theare are better examples, I'd like to know them.
rileykarson added a commit to rileykarson/terraform-provider-google that referenced this pull request Nov 12, 2018
rileykarson pushed a commit that referenced this pull request Nov 13, 2018
Hi!

Now any changes of cloud build trigger create new one, this PR makes triggers modifiable in place.

I referred to [bigquery dataset](https://github.com/terraform-providers/terraform-provider-google/blob/9f0b792f091ce1a27f718d23184a481d6b20ec05/google/resource_bigquery_dataset.go#L353). If theare are better examples, I'd like to know them.
rileykarson added a commit that referenced this pull request Nov 13, 2018
@nownabe nownabe deleted the cloudbuild-update branch November 28, 2018 23:22
nat-henderson pushed a commit that referenced this pull request Dec 4, 2018
Hi!

Now any changes of cloud build trigger create new one, this PR makes triggers modifiable in place.

I referred to [bigquery dataset](https://github.com/terraform-providers/terraform-provider-google/blob/9f0b792f091ce1a27f718d23184a481d6b20ec05/google/resource_bigquery_dataset.go#L353). If theare are better examples, I'd like to know them.
nat-henderson pushed a commit that referenced this pull request Dec 5, 2018
Hi!

Now any changes of cloud build trigger create new one, this PR makes triggers modifiable in place.

I referred to [bigquery dataset](https://github.com/terraform-providers/terraform-provider-google/blob/9f0b792f091ce1a27f718d23184a481d6b20ec05/google/resource_bigquery_dataset.go#L353). If theare are better examples, I'd like to know them.
nat-henderson pushed a commit that referenced this pull request Dec 5, 2018
nat-henderson pushed a commit that referenced this pull request Dec 5, 2018
Hi!

Now any changes of cloud build trigger create new one, this PR makes triggers modifiable in place.

I referred to [bigquery dataset](https://github.com/terraform-providers/terraform-provider-google/blob/9f0b792f091ce1a27f718d23184a481d6b20ec05/google/resource_bigquery_dataset.go#L353). If theare are better examples, I'd like to know them.
@ghost
Copy link

ghost commented Dec 13, 2018

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Dec 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants