Importing google_dns_managed_zone with project #1944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 26, 2018 10:04
- added tests and acceptance tests
paddycarver
suggested changes
Aug 30, 2018
| or by using `project-id` and `name` e.g. | ||
|
|
||
| ``` | ||
| $ terraform import google_dns_managed_zone.foo project/managedZones/foo-zone |
There was a problem hiding this comment.
nitpick: could we maybe use project-id instead of project, to make it clear that project isn't a hardcoded string, and to match the description?
There was a problem hiding this comment.
Sorry for the delay.
Sure. I documented all import formats like on compute disk using project-id
paddycarver
approved these changes
Sep 20, 2018
chrisst
pushed a commit
to chrisst/terraform-provider-google
that referenced
this pull request
Nov 9, 2018
Importing google_dns_managed_zone with project
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
importing Cloud DNS managed zones from a different project.
Any comments are welcome. Esp. on doing acceptance tests with a different project are very welcome.
See also #1676