Add Policy, Attestor, and Note resources for Binary Authorization #1885
Conversation
|
@ndmckinley in case you want to look at it now, here it is. I found another opportunity to break off some changes separately so I'm going to do that so this isn't crowded with changes to every other resource. |
modular-magician
force-pushed
the
codegen-pr-406
branch
2 times, most recently
from
b2354c9 to
8951bb7
Compare
| "github.com/hashicorp/terraform/helper/schema" | ||
| ) | ||
|
|
||
| func resourceBinaryauthorizationAttestor() *schema.Resource { |
There was a problem hiding this comment.
Can we fix this capitalization? I did it with a hack for ResourceManager iirc.
There was a problem hiding this comment.
Yup! I fixed the hack too.
| `, name, name, armoredPubKey) | ||
| } | ||
|
|
||
| const armoredPubKey = `mQENBFtP0doBCADF+joTiXWKVuP8kJt3fgpBSjT9h8ezMfKA4aXZctYLx5wslWQl |
There was a problem hiding this comment.
Is this some particular key, or just a valid one we happen to have?
There was a problem hiding this comment.
Just a valid one, I added a comment.
modular-magician
force-pushed
the
codegen-pr-406
branch
5 times, most recently
from
798d263 to
829b531
Compare
|
All right, I've been fighting with these tests and the magician for the past 2 days now but this is finally ready for review again. Tests are passing. |
| return nil, err | ||
| } | ||
| transformed["id"] = transformedId | ||
| transformedAsciiArmoredPgpPublicKey, err := expandBinaryAuthorizationAttestorAttestationAuthorityNotePublicKeysAsciiArmoredPgpPublicKey(original["ascii_armored_pgp_public_key"], d, config) |
There was a problem hiding this comment.
These names get a little crazy, don't they?
| }, | ||
|
|
||
| Schema: map[string]*schema.Schema{ | ||
| "attestation_authority": { |
There was a problem hiding this comment.
This whole thing is just a single string, right? It's a little messy for users ... is it a lot of work to collapse nested objects?
There was a problem hiding this comment.
Talked about this over chat, but for others- yes, it would be a lot of work. Right now we can rename things easily but we don't have an easy way to change the type of a field- the best we'd be able to do is a lot of custom code, which we don't want to do.
modular-magician
force-pushed
the
codegen-pr-406
branch
from
f02b49c to
8872d9d
Compare
…shicorp#1885) <!-- This change is generated by MagicModules. --> /cc @danawillow
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
/cc @danawillow