CloudBuild Trigger substitutions #1810
Conversation
|
Tests pass. |
| @@ -233,6 +239,10 @@ resource "google_cloudbuild_trigger" "filename_build_trigger" { | |||
| project = "${google_project_services.acceptance.project}" | |||
| repo_name = "some-repo" | |||
| } | |||
| substitutions { | |||
There was a problem hiding this comment.
nit - this indent is wrong. Also, these substitutions seem to break the first rule that says "uppercase letters only/must start with _", which I would assume would make the tests fail. Do they actually work and docs are just lying?
There was a problem hiding this comment.
They work, and the docs aren't lying - if you tried to use this trigger, it would break. While I'm here I'll go ahead and fix that.
|
Lovely |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Adds substitutions to Cloud Build Triggers, fixes #1802. Also adds project-imports so that you can import it even if it's not using the provider-default project (whoops) and adds that to the tests.