Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't call full read when updating billing acct #1795

Merged
merged 1 commit into from
Jul 19, 2018

Conversation

danawillow
Copy link
Contributor

I also fixed the time.sleep call to use 3 seconds, which I think was the original intent (vs 3 nanoseconds, boy is that an unintuitive result)

Fixes #1791.

@danawillow danawillow requested a review from paddycarver July 19, 2018 19:21
@danawillow
Copy link
Contributor Author

Oh, should probably explain why this is the fix. So when we called the full read() function before, that does all the d.Sets based on what the API returns. Since app engine hasn't been set up at that point, it does a d.Set on the app engine block to be empty. Then, we attempt to set up app engine but the block is now empty, so it doesn't get created.

Copy link
Contributor

@paddycarver paddycarver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the wildest PR. I love it. There's so much good stuff going on here. :D

@danawillow danawillow merged commit 080f6fe into hashicorp:master Jul 19, 2018
@danawillow danawillow deleted the is-1791 branch July 19, 2018 20:32
@ghost
Copy link

ghost commented Nov 17, 2018

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GAE instance creation silently fails on google_project resource but reports complete
2 participants