Make email, project computed for GCE default service account

[emilymye]

Fixes #1686

[emilymye]

TF_ACC=1 go test ./google -v --run="TestAccDataSourceGoogleComputeDefaultServiceAccount_basic" -timeout 120m
=== RUN TestAccDataSourceGoogleComputeDefaultServiceAccount_basic
=== PAUSE TestAccDataSourceGoogleComputeDefaultServiceAccount_basic
=== CONT TestAccDataSourceGoogleComputeDefaultServiceAccount_basic
--- PASS: TestAccDataSourceGoogleComputeDefaultServiceAccount_basic (1.35s)
PASS
ok github.com/terraform-providers/terraform-provider-google/google 1.548s

[paddycarver]

Why does this make email no longer user-specifiable? Isn't this a breaking change for users that would have had the email field specified?

I think it's justifiable in this case, as the field was documented to be un-specifiable. But I just wanted to check and see if my understanding of the situation was right, which is that it was Optional by mistake.

[danawillow]

Yeah, if you look at the code email is never d.Get-ed (d.gotten?) so setting it wouldn't do anything anyway.

[emilymye]

Should I still just go ahead and merge it in if it's a breaking change?

[danawillow]

I'm very confident that this is not a breaking change.

[paddycarver]

Just chiming in late that now that I understand what's going on here, I also am 👍 on this being merged now and not considering it a breaking change.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!