-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow unlinking of billing account. #138
Allow unlinking of billing account. #138
Conversation
7659c0b
to
c7e4ad1
Compare
This code makes sense to me, @ubschmidt2. Great catch, and thanks for tackling the PR. It looks like this is your first contribution (but I could be getting deceived by the recent repo split). If it is, congratulations and welcome! If you're having any trouble with acceptance tests, feel free to reach out. |
(I realise I didn't explicitly say this, but I was waiting on the acceptance tests you have as a TODO before merging. Figured this was a WIP. :) ) |
Added acceptance tests. PTAL. |
…d of setting an empty billing account.
Looks good, thanks! Fixes #133. |
* Allow unlinking of billing account. Closes hashicorp#133 * Add acceptance test for unlinking the billing account. * Just apply the resource definition without the billing account instead of setting an empty billing account.
…e_google_gen_deps Update vendored libraries to same commit.
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
No description provided.