Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow unlinking of billing account. #138

Merged
merged 3 commits into from
Jul 12, 2017

Conversation

ubschmidt2
Copy link
Contributor

@ubschmidt2 ubschmidt2 commented Jun 16, 2017

No description provided.

@ubschmidt2 ubschmidt2 changed the title Allow unlinking of billing account. Closes #133 Allow unlinking of billing account. Jun 17, 2017
@ubschmidt2 ubschmidt2 force-pushed the unlink-billing-account branch from 7659c0b to c7e4ad1 Compare June 17, 2017 00:06
@paddycarver
Copy link
Contributor

This code makes sense to me, @ubschmidt2. Great catch, and thanks for tackling the PR. It looks like this is your first contribution (but I could be getting deceived by the recent repo split). If it is, congratulations and welcome!

If you're having any trouble with acceptance tests, feel free to reach out.

@paddycarver
Copy link
Contributor

(I realise I didn't explicitly say this, but I was waiting on the acceptance tests you have as a TODO before merging. Figured this was a WIP. :) )

@ubschmidt2 ubschmidt2 changed the title Allow unlinking of billing account. WIP: Allow unlinking of billing account. Jul 5, 2017
@ubschmidt2
Copy link
Contributor Author

Added acceptance tests. PTAL.

@ubschmidt2 ubschmidt2 changed the title WIP: Allow unlinking of billing account. Allow unlinking of billing account. Jul 5, 2017
@danawillow
Copy link
Contributor

Looks good, thanks!

Fixes #133.

@danawillow danawillow merged commit e6e91ec into hashicorp:master Jul 12, 2017
negz pushed a commit to negz/terraform-provider-google that referenced this pull request Oct 17, 2017
* Allow unlinking of billing account. Closes hashicorp#133

* Add acceptance test for unlinking the billing account.

* Just apply the resource definition without the billing account instead of setting an empty billing account.
luis-silva pushed a commit to luis-silva/terraform-provider-google that referenced this pull request May 21, 2019
…e_google_gen_deps

Update vendored libraries to same commit.
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants